Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32263 )
Change subject: google/kukui: Include panel identifier (LCM ID) into SKU ID ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c... PS5, Line 26: KUKUI_LCM_ID_CHANNEL = 2,
LCd Module. […]
okay
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c... PS5, Line 28: KUKUI_ nit: btw, this is a file-local #define in a kukui-specific file, the KUKUI_ prefix is a bit superfluous.
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c... PS5, Line 33: static const int voltages_default[] = {
I thought about that, but then it's harder to choose ARRAY_SIZE. […]
You'd need to pass the size in another parameter as well, of course. (If you don't like the duplication you could solve it with a macro, but I don't think that's worth it...
get_index(CHANNEL_SKU, voltages_default, ARRAY_SIZE(voltages_default))
doesn't look that bad.)