Patch Set 5:

Patch Set 5:

Patch Set 5:

Why was this merged? Furquan has a point.

oops, i thought Furquan said, lets not replicate this for Google ADL boards where partners need more configurability

Alright. I think we can wait until some Google ADL boards are in the tree, then restructure memcfg to better reflect LPDDR byte mapping logic.

Yes, let's do that. I think it is important to keep the translation from schematics to mainboard description as simple and straightfoward as possible. The complexities can be hidden inside SoC code to translate into appropriate UPDs, etc. This makes life easier for mainboard developers.

View Change

1 comment:

To view, visit change 48077. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64f2b38492934c8ede301f4b252c8700060ed4ac
Gerrit-Change-Number: 48077
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath@intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com>
Gerrit-Comment-Date: Mon, 07 Dec 2020 19:25:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Subrata Banik <subrata.banik@intel.com>
Gerrit-MessageType: comment