Edward O'Callaghan has uploaded this change for review.

View Change

mb/google/hatch: Toggle on EC_ENABLE_LID_SWITCH

Unfortunately EC_ENABLE_LID_SWITCH needs to be toggled on
to enable the 'PNP0C0D' ASL device on otherwise the wake
pin will not be noticed by the kernel. This patch works
around that issue for Puff and Puff variants.

BUG=b:152913653
BRANCH=none
TEST=builds

Change-Id: I2f40afb7aa62510312164d3a62d44f4b2b911700
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
---
M src/mainboard/google/hatch/variants/duffy/include/variant/ec.h
M src/mainboard/google/hatch/variants/kaisa/include/variant/ec.h
M src/mainboard/google/hatch/variants/puff/include/variant/ec.h
3 files changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/40517/1

diff --git a/src/mainboard/google/hatch/variants/duffy/include/variant/ec.h b/src/mainboard/google/hatch/variants/duffy/include/variant/ec.h
index 5e2043f..9f9b4a9 100644
--- a/src/mainboard/google/hatch/variants/duffy/include/variant/ec.h
+++ b/src/mainboard/google/hatch/variants/duffy/include/variant/ec.h
@@ -49,6 +49,8 @@
  * Note that GPE_EC_WAKE is defined, confusingly, as GPE_LAN_WAK which is GPD2/LAN_WAKE#
  * on the PCH or as the line EC_PCH_WAKE_ODL on the schematic.
  */
+/* Enable LID switch such that the wake pin works for the EC */
+#define EC_ENABLE_LID_SWITCH
 #define EC_ENABLE_WAKE_PIN	GPE_EC_WAKE
 
 #define SIO_EC_MEMMAP_ENABLE	/* EC Memory Map Resources */
diff --git a/src/mainboard/google/hatch/variants/kaisa/include/variant/ec.h b/src/mainboard/google/hatch/variants/kaisa/include/variant/ec.h
index 5e2043f..9f9b4a9 100644
--- a/src/mainboard/google/hatch/variants/kaisa/include/variant/ec.h
+++ b/src/mainboard/google/hatch/variants/kaisa/include/variant/ec.h
@@ -49,6 +49,8 @@
  * Note that GPE_EC_WAKE is defined, confusingly, as GPE_LAN_WAK which is GPD2/LAN_WAKE#
  * on the PCH or as the line EC_PCH_WAKE_ODL on the schematic.
  */
+/* Enable LID switch such that the wake pin works for the EC */
+#define EC_ENABLE_LID_SWITCH
 #define EC_ENABLE_WAKE_PIN	GPE_EC_WAKE
 
 #define SIO_EC_MEMMAP_ENABLE	/* EC Memory Map Resources */
diff --git a/src/mainboard/google/hatch/variants/puff/include/variant/ec.h b/src/mainboard/google/hatch/variants/puff/include/variant/ec.h
index 5e2043f..9f9b4a9 100644
--- a/src/mainboard/google/hatch/variants/puff/include/variant/ec.h
+++ b/src/mainboard/google/hatch/variants/puff/include/variant/ec.h
@@ -49,6 +49,8 @@
  * Note that GPE_EC_WAKE is defined, confusingly, as GPE_LAN_WAK which is GPD2/LAN_WAKE#
  * on the PCH or as the line EC_PCH_WAKE_ODL on the schematic.
  */
+/* Enable LID switch such that the wake pin works for the EC */
+#define EC_ENABLE_LID_SWITCH
 #define EC_ENABLE_WAKE_PIN	GPE_EC_WAKE
 
 #define SIO_EC_MEMMAP_ENABLE	/* EC Memory Map Resources */

To view, visit change 40517. To unsubscribe, or for help writing mail filters, visit settings.