Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39639 )
Change subject: Revert "src/mb/google/volteer: Add camera ACPI configuration" ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review-1
The patch was for temporary use until we completely move to SSDT. The temporal DSDT patch is needed for camera validation and power on works. I'll revert it once SSDT patch is merged.
It was already communicated that the static ASL change will not be merged upstream. It was supposed to be cherry-picked for any validation/testing.
In the future, can you please ensure that the CLs that you push for volteer/tgl have nvaccaro@ and caveh@ as reviewers.
mipi_camera.asl needs a number of clean ups.
Do you have an ETA on when SSDT changes would be ready?
#1, We did not expect the patch for volteer was merged soon and it was prepared for cherry pick for proto2 PO as Nick's cheery pick patch will not work as it is. Daniel created patch based on last review feedback(clean up and update acpi based on Camera spec) which is same as TGL RVP patch. #2, We planed to add more reviewer soon but it's merged before adding. The patch for TGL RVP included Google engineers. #3, We're preparing ETA with JSL team as SSDT for Camera is common module change. We'll update soon.
I think we can remove this DSDT acpi change when we push SSDT change.