Attention is currently required from: Tarun Tuli, Kapil Porwal, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72835 )
Change subject: soc/intel/{common, meteorlake}: Add support for new MCH
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/meteorlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/72835/comment/3f2efa73_ef39f4ac
PS1, Line 184: case PCI_DID_INTEL_MTL_P_ID_5:
: soc_config = &config->power_limits_config[MTL_P_POWER_LIMITS_5];
this is dead code at this moment as we are not overriding anything per SKU. does it make sense still adding new entry here ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72835
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c9ce5c58e4bdec5e7245840f0892d651922cd9
Gerrit-Change-Number: 72835
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Mon, 06 Feb 2023 08:08:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment