Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46409 )
Change subject: soc/mediatek/mt8192: eint: unmask eint event mask register ......................................................................
Patch Set 57:
(8 comments)
https://review.coreboot.org/c/coreboot/+/46409/57//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46409/57//COMMIT_MSG@9 PS57, Line 9: can I'm not sure what this means. Maybe "will"? Does the registers mask eint wakeup source by default?
https://review.coreboot.org/c/coreboot/+/46409/57//COMMIT_MSG@10 PS57, Line 10: Most Since most
https://review.coreboot.org/c/coreboot/+/46409/57//COMMIT_MSG@12 PS57, Line 12: set the setting set the registers.
https://review.coreboot.org/c/coreboot/+/46409/57/src/soc/mediatek/mt8192/ei... File src/soc/mediatek/mt8192/eint_event.c:
https://review.coreboot.org/c/coreboot/+/46409/57/src/soc/mediatek/mt8192/ei... PS57, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ One blank line after header.
https://review.coreboot.org/c/coreboot/+/46409/57/src/soc/mediatek/mt8192/ei... PS57, Line 6: uint32_t int
https://review.coreboot.org/c/coreboot/+/46409/57/src/soc/mediatek/mt8192/ei... PS57, Line 7: 7 ARRAY_SIZE(mtk_eint_event->eint_event_mask_clr)
https://review.coreboot.org/c/coreboot/+/46409/57/src/soc/mediatek/mt8192/ei... PS57, Line 10: Remove extra blank line.
https://review.coreboot.org/c/coreboot/+/46409/57/src/soc/mediatek/mt8192/in... File src/soc/mediatek/mt8192/include/soc/eint_event.h:
https://review.coreboot.org/c/coreboot/+/46409/57/src/soc/mediatek/mt8192/in... PS57, Line 4: #define SOC_MEDIATEK_MT8192_EINT_EVENT_H One blank line after this.