Felix Held submitted this change.

View Change

soc/amd/*/acpi: drop CRAT TODO

The CRAT (Component Resource Attribute Table) isn't used on the APUs
from Renoir on and has also been marked as deprecated in version 6.5 of
the ACPI specification. So remove the 'TODO: look into adding CRAT'
comment from all SoCs from Renoir/Cezanne on.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I3ea1e3678608b0ace2a1ff7fc104594e90c91476
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80227
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/soc/amd/cezanne/acpi.c
M src/soc/amd/glinda/acpi.c
M src/soc/amd/mendocino/acpi.c
M src/soc/amd/phoenix/acpi.c
4 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/src/soc/amd/cezanne/acpi.c b/src/soc/amd/cezanne/acpi.c
index c99159a..f60512d 100644
--- a/src/soc/amd/cezanne/acpi.c
+++ b/src/soc/amd/cezanne/acpi.c
@@ -58,8 +58,6 @@
 unsigned long soc_acpi_write_tables(const struct device *device, unsigned long current,
 				    acpi_rsdp_t *rsdp)
 {
-	/* TODO: look into adding CRAT */
-
 	/* IVRS */
 	current = acpi_add_ivrs_table(current, rsdp);
 
diff --git a/src/soc/amd/glinda/acpi.c b/src/soc/amd/glinda/acpi.c
index 8b6031c..eb1d478 100644
--- a/src/soc/amd/glinda/acpi.c
+++ b/src/soc/amd/glinda/acpi.c
@@ -61,8 +61,6 @@
 unsigned long soc_acpi_write_tables(const struct device *device, unsigned long current,
 				    acpi_rsdp_t *rsdp)
 {
-	/* TODO: look into adding CRAT */
-
 	/* IVRS */
 	current = acpi_add_ivrs_table(current, rsdp);
 
diff --git a/src/soc/amd/mendocino/acpi.c b/src/soc/amd/mendocino/acpi.c
index 898e75e..e7f0d96 100644
--- a/src/soc/amd/mendocino/acpi.c
+++ b/src/soc/amd/mendocino/acpi.c
@@ -60,8 +60,6 @@
 unsigned long soc_acpi_write_tables(const struct device *device, unsigned long current,
 				    acpi_rsdp_t *rsdp)
 {
-	/* TODO: look into adding CRAT */
-
 	/* IVRS */
 	current = acpi_add_ivrs_table(current, rsdp);
 
diff --git a/src/soc/amd/phoenix/acpi.c b/src/soc/amd/phoenix/acpi.c
index a8be10e..a6482ee 100644
--- a/src/soc/amd/phoenix/acpi.c
+++ b/src/soc/amd/phoenix/acpi.c
@@ -61,8 +61,6 @@
 unsigned long soc_acpi_write_tables(const struct device *device, unsigned long current,
 				    acpi_rsdp_t *rsdp)
 {
-	/* TODO: look into adding CRAT */
-
 	/* IVRS */
 	current = acpi_add_ivrs_table(current, rsdp);
 

To view, visit change 80227. To unsubscribe, or for help writing mail filters, visit settings.