Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved 
mb/*/*/dsdt.asl: Drop useless comments in DefinitionBlock()

Change-Id: I1e0489ec6730760f74102cdd00e4aaa66975d69a
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45801
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
---
M src/mainboard/amd/gardenia/dsdt.asl
M src/mainboard/amd/inagua/dsdt.asl
M src/mainboard/amd/mandolin/dsdt.asl
M src/mainboard/amd/olivehill/dsdt.asl
M src/mainboard/amd/padmelon/dsdt.asl
M src/mainboard/amd/parmer/dsdt.asl
M src/mainboard/amd/persimmon/dsdt.asl
M src/mainboard/amd/south_station/dsdt.asl
M src/mainboard/amd/thatcher/dsdt.asl
M src/mainboard/amd/union_station/dsdt.asl
M src/mainboard/asrock/e350m1/dsdt.asl
M src/mainboard/asrock/imb-a180/dsdt.asl
M src/mainboard/asus/a88xm-e/dsdt.asl
M src/mainboard/asus/am1i-a/dsdt.asl
M src/mainboard/asus/f2a85-m/dsdt.asl
M src/mainboard/bap/ode_e20XX/dsdt.asl
M src/mainboard/biostar/a68n_5200/dsdt.asl
M src/mainboard/biostar/am1ml/dsdt.asl
M src/mainboard/elmex/pcm205400/dsdt.asl
M src/mainboard/emulation/qemu-i440fx/dsdt.asl
M src/mainboard/emulation/qemu-q35/dsdt.asl
M src/mainboard/gizmosphere/gizmo/dsdt.asl
M src/mainboard/gizmosphere/gizmo2/dsdt.asl
M src/mainboard/google/kahlee/dsdt.asl
M src/mainboard/google/zork/dsdt.asl
M src/mainboard/hp/abm/dsdt.asl
M src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl
M src/mainboard/jetway/nf81-t56n-lf/dsdt.asl
M src/mainboard/lenovo/g505s/dsdt.asl
M src/mainboard/lippert/frontrunner-af/dsdt.asl
M src/mainboard/msi/ms7721/dsdt.asl
M src/mainboard/pcengines/apu1/dsdt.asl
M src/mainboard/pcengines/apu2/dsdt.asl
33 files changed, 35 insertions(+), 35 deletions(-)

diff --git a/src/mainboard/amd/gardenia/dsdt.asl b/src/mainboard/amd/gardenia/dsdt.asl
index 42136e6..38cd34c 100644
--- a/src/mainboard/amd/gardenia/dsdt.asl
+++ b/src/mainboard/amd/gardenia/dsdt.asl
@@ -6,7 +6,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/amd/inagua/dsdt.asl b/src/mainboard/amd/inagua/dsdt.asl
index 16d12ed..92591d7 100644
--- a/src/mainboard/amd/inagua/dsdt.asl
+++ b/src/mainboard/amd/inagua/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/amd/mandolin/dsdt.asl b/src/mainboard/amd/mandolin/dsdt.asl
index bb4d6c9..d2fa4ad 100644
--- a/src/mainboard/amd/mandolin/dsdt.asl
+++ b/src/mainboard/amd/mandolin/dsdt.asl
@@ -6,7 +6,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/amd/olivehill/dsdt.asl b/src/mainboard/amd/olivehill/dsdt.asl
index 924db51..59677a7 100644
--- a/src/mainboard/amd/olivehill/dsdt.asl
+++ b/src/mainboard/amd/olivehill/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/amd/padmelon/dsdt.asl b/src/mainboard/amd/padmelon/dsdt.asl
index 9ef76c4..f4cb15f 100644
--- a/src/mainboard/amd/padmelon/dsdt.asl
+++ b/src/mainboard/amd/padmelon/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/amd/parmer/dsdt.asl b/src/mainboard/amd/parmer/dsdt.asl
index f932776..940487f 100644
--- a/src/mainboard/amd/parmer/dsdt.asl
+++ b/src/mainboard/amd/parmer/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",			/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/amd/persimmon/dsdt.asl b/src/mainboard/amd/persimmon/dsdt.asl
index 16d12ed..92591d7 100644
--- a/src/mainboard/amd/persimmon/dsdt.asl
+++ b/src/mainboard/amd/persimmon/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/amd/south_station/dsdt.asl b/src/mainboard/amd/south_station/dsdt.asl
index 16d12ed..92591d7 100644
--- a/src/mainboard/amd/south_station/dsdt.asl
+++ b/src/mainboard/amd/south_station/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/amd/thatcher/dsdt.asl b/src/mainboard/amd/thatcher/dsdt.asl
index f932776..940487f 100644
--- a/src/mainboard/amd/thatcher/dsdt.asl
+++ b/src/mainboard/amd/thatcher/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",			/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/amd/union_station/dsdt.asl b/src/mainboard/amd/union_station/dsdt.asl
index 16d12ed..92591d7 100644
--- a/src/mainboard/amd/union_station/dsdt.asl
+++ b/src/mainboard/amd/union_station/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/asrock/e350m1/dsdt.asl b/src/mainboard/asrock/e350m1/dsdt.asl
index 1267ddc..27f9de0 100644
--- a/src/mainboard/asrock/e350m1/dsdt.asl
+++ b/src/mainboard/asrock/e350m1/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/asrock/imb-a180/dsdt.asl b/src/mainboard/asrock/imb-a180/dsdt.asl
index 924db51..59677a7 100644
--- a/src/mainboard/asrock/imb-a180/dsdt.asl
+++ b/src/mainboard/asrock/imb-a180/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/asus/a88xm-e/dsdt.asl b/src/mainboard/asus/a88xm-e/dsdt.asl
index 7de3281..a72fa36 100644
--- a/src/mainboard/asus/a88xm-e/dsdt.asl
+++ b/src/mainboard/asus/a88xm-e/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",			/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/asus/am1i-a/dsdt.asl b/src/mainboard/asus/am1i-a/dsdt.asl
index 67b39b1..d5e1e18 100644
--- a/src/mainboard/asus/am1i-a/dsdt.asl
+++ b/src/mainboard/asus/am1i-a/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/asus/f2a85-m/dsdt.asl b/src/mainboard/asus/f2a85-m/dsdt.asl
index 76d7983..3f72eb1 100644
--- a/src/mainboard/asus/f2a85-m/dsdt.asl
+++ b/src/mainboard/asus/f2a85-m/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",			/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/bap/ode_e20XX/dsdt.asl b/src/mainboard/bap/ode_e20XX/dsdt.asl
index 924db51..59677a7 100644
--- a/src/mainboard/bap/ode_e20XX/dsdt.asl
+++ b/src/mainboard/bap/ode_e20XX/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/biostar/a68n_5200/dsdt.asl b/src/mainboard/biostar/a68n_5200/dsdt.asl
index 924db51..59677a7 100644
--- a/src/mainboard/biostar/a68n_5200/dsdt.asl
+++ b/src/mainboard/biostar/a68n_5200/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/biostar/am1ml/dsdt.asl b/src/mainboard/biostar/am1ml/dsdt.asl
index 2e49953d4..e8b99f4 100644
--- a/src/mainboard/biostar/am1ml/dsdt.asl
+++ b/src/mainboard/biostar/am1ml/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/elmex/pcm205400/dsdt.asl b/src/mainboard/elmex/pcm205400/dsdt.asl
index 16d12ed..92591d7 100644
--- a/src/mainboard/elmex/pcm205400/dsdt.asl
+++ b/src/mainboard/elmex/pcm205400/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/emulation/qemu-i440fx/dsdt.asl b/src/mainboard/emulation/qemu-i440fx/dsdt.asl
index 6b3061b..6fd4467 100644
--- a/src/mainboard/emulation/qemu-i440fx/dsdt.asl
+++ b/src/mainboard/emulation/qemu-i440fx/dsdt.asl
@@ -3,8 +3,8 @@
 
 #include <acpi/acpi.h>
 DefinitionBlock (
-	"dsdt.aml",         // Output Filename
-	"DSDT",             // Signature
+	"dsdt.aml",
+	"DSDT",
 	ACPI_DSDT_REV_1,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/emulation/qemu-q35/dsdt.asl b/src/mainboard/emulation/qemu-q35/dsdt.asl
index 41065df..d89d67f 100644
--- a/src/mainboard/emulation/qemu-q35/dsdt.asl
+++ b/src/mainboard/emulation/qemu-q35/dsdt.asl
@@ -7,8 +7,8 @@
 
 #include <acpi/acpi.h>
 DefinitionBlock (
-	"dsdt.aml",         // Output Filename
-	"DSDT",             // Signature
+	"dsdt.aml",
+	"DSDT",
 	ACPI_DSDT_REV_1,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/gizmosphere/gizmo/dsdt.asl b/src/mainboard/gizmosphere/gizmo/dsdt.asl
index 34304a8..c5ad8c8 100644
--- a/src/mainboard/gizmosphere/gizmo/dsdt.asl
+++ b/src/mainboard/gizmosphere/gizmo/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/gizmosphere/gizmo2/dsdt.asl b/src/mainboard/gizmosphere/gizmo2/dsdt.asl
index 924db51..59677a7 100644
--- a/src/mainboard/gizmosphere/gizmo2/dsdt.asl
+++ b/src/mainboard/gizmosphere/gizmo2/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/google/kahlee/dsdt.asl b/src/mainboard/google/kahlee/dsdt.asl
index f7f20cd..c3ffd5b 100644
--- a/src/mainboard/google/kahlee/dsdt.asl
+++ b/src/mainboard/google/kahlee/dsdt.asl
@@ -6,7 +6,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/google/zork/dsdt.asl b/src/mainboard/google/zork/dsdt.asl
index 9790737..a96d47c 100644
--- a/src/mainboard/google/zork/dsdt.asl
+++ b/src/mainboard/google/zork/dsdt.asl
@@ -7,7 +7,7 @@
 
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/hp/abm/dsdt.asl b/src/mainboard/hp/abm/dsdt.asl
index 924db51..59677a7 100644
--- a/src/mainboard/hp/abm/dsdt.asl
+++ b/src/mainboard/hp/abm/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl b/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl
index f7f4ef8..da03899 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl
+++ b/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl
@@ -6,7 +6,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",			/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl b/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl
index 43a3971..17462ac 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl
+++ b/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/lenovo/g505s/dsdt.asl b/src/mainboard/lenovo/g505s/dsdt.asl
index f41aab5..57b535a 100644
--- a/src/mainboard/lenovo/g505s/dsdt.asl
+++ b/src/mainboard/lenovo/g505s/dsdt.asl
@@ -6,7 +6,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",			/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl
index 0a442d8..ffae0d9 100644
--- a/src/mainboard/lippert/frontrunner-af/dsdt.asl
+++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",                 /* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/msi/ms7721/dsdt.asl b/src/mainboard/msi/ms7721/dsdt.asl
index 93cd02a..25d5ef2 100644
--- a/src/mainboard/msi/ms7721/dsdt.asl
+++ b/src/mainboard/msi/ms7721/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",			/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/pcengines/apu1/dsdt.asl b/src/mainboard/pcengines/apu1/dsdt.asl
index 71b82c9..047750d 100644
--- a/src/mainboard/pcengines/apu1/dsdt.asl
+++ b/src/mainboard/pcengines/apu1/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,
diff --git a/src/mainboard/pcengines/apu2/dsdt.asl b/src/mainboard/pcengines/apu2/dsdt.asl
index f33c524..94bfe63 100644
--- a/src/mainboard/pcengines/apu2/dsdt.asl
+++ b/src/mainboard/pcengines/apu2/dsdt.asl
@@ -4,7 +4,7 @@
 #include <acpi/acpi.h>
 DefinitionBlock (
 	"dsdt.aml",
-	"DSDT",		/* Signature */
+	"DSDT",
 	ACPI_DSDT_REV_2,
 	OEM_ID,
 	ACPI_TABLE_CREATOR,

To view, visit change 45801. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e0489ec6730760f74102cdd00e4aaa66975d69a
Gerrit-Change-Number: 45801
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged