Patrick Georgi submitted this change.
mb/google/volteer: Change wake to be triggered on a raising edge
ACPI_GPIO_IRQ_EDGE_BOTH sets both edges as wake. The desired behavior is wake on rising edge, change to ACPI_GPIO_INPUT_ACTIVE_LOW.
Fixing for both Volteer and Volteer2 variants.
BUG=b:146083964
BRANCH=None
TEST=tested on a Volteer
Change-Id: I2d3339151bf4e2cbae60aaf97ba1bd7909a2b9a9
Signed-off-by: Alex Levin <levinale@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44089
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
---
M src/mainboard/google/volteer/variants/volteer/overridetree.cb
M src/mainboard/google/volteer/variants/volteer2/overridetree.cb
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
index c7350cb..d4bd7f4 100644
--- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
@@ -114,7 +114,7 @@
chip drivers/generic/gpio_keys
register "name" = ""PENH""
# GPP_B3 is the IRQ source, and GPP_E1 is the wake source
- register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_B3)"
+ register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_B3)"
register "key.wake_gpe" = "GPE0_DW2_01"
register "key.wakeup_route" = "WAKEUP_ROUTE_SCI"
register "key.wakeup_event_action" = "EV_ACT_DEASSERTED"
diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb
index 8e5985e..62749fc 100644
--- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb
@@ -70,7 +70,7 @@
chip drivers/generic/gpio_keys
register "name" = ""PENH""
# GPP_B3 is the IRQ source, and GPP_E1 is the wake source
- register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_B3)"
+ register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_B3)"
register "key.wake_gpe" = "GPE0_DW2_01"
register "key.wakeup_route" = "WAKEUP_ROUTE_SCI"
register "key.wakeup_event_action" = "EV_ACT_DEASSERTED"
To view, visit change 44089. To unsubscribe, or for help writing mail filters, visit settings.