Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Paul Menzel.
6 comments:
File src/soc/intel/common/block/acpi/Kconfig:
nit
`Event`
File src/soc/intel/common/block/acpi/acpi.c:
Patch Set #11, Line 108: fadt->gpe0_blk_len = 2 * GPE0_REG_MAX * sizeof(uint32_t);
move this at line #106?
Patch Set #11, Line 109: !fadt->gpe1_blk
again same mistake.
```
if (fadt->gpe1_blk) {
...
}
```
Patch Set #11, Line 110: gpe0_blk_len
shouldn't this be `fadt->gpe1_blk_len`
should be `gpe1_blk_len` as per ACPI spec?
```
GPE0_BLK_LEN 1 92 The length of the register whose address is given by
X_GPE0_BLK (if nonzero) or by GPE0_BLK (otherwise) in bytes. The value is a non-negative multiple of 2.
GPE1_BLK_LEN 1 93 The length of the register whose address is given by
X_GPE1_BLK (if nonzero) or by GPE1_BLK (otherwise) in bytes. The value is a non-negative multiple of 2.
GPE1_BASE 1 94 Offset within the ACPI general-purpose event model
where GPE1 based events start
```
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
In addition, the following SOC GPE1 defines are required in common
* code but not present in older platform headers. Therefore, the dummy entries
* are added here for platforms without GPE1 support.
move this highlighted comment above line #11 as its applicable there
To view, visit change 84103. To unsubscribe, or for help writing mail filters, visit settings.