Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email )
Change subject: soc/mediatek/mt8196: Add DDP driver ......................................................................
Patch Set 5:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85950/comment/10404dd3_4f1e2be2?usp... : PS4, Line 9: controller
Yes, I should correct this. […]
Done
File src/soc/mediatek/mt8196/ddp.c:
https://review.coreboot.org/c/coreboot/+/85950/comment/e5a06c3f_40a7108c?usp... : PS3, Line 30: default:
Ok, I will fix it.
Done
File src/soc/mediatek/mt8196/ddp.c:
https://review.coreboot.org/c/coreboot/+/85950/comment/6389d521_81163681?usp... : PS4, Line 268: clrsetbits32
OK, I will fix it.
Done
https://review.coreboot.org/c/coreboot/+/85950/comment/f03c6881_e350f4c4?usp... : PS4, Line 269: clrsetbits32
OK, I will fix it.
Done
File src/soc/mediatek/mt8196/include/soc/ddp.h:
https://review.coreboot.org/c/coreboot/+/85950/comment/0c5c5787_a85febde?usp... : PS3, Line 190: };
OK, I will fix it.
Done
https://review.coreboot.org/c/coreboot/+/85950/comment/ef50588d_2e5e340c?usp... : PS3, Line 227: };
OK, I will fix it.
Done
https://review.coreboot.org/c/coreboot/+/85950/comment/3e2a3b05_8ee51c91?usp... : PS3, Line 254: };
OK, I will fix it.
Done