Angel Pons has uploaded this change for review.
mb/prodrive/hermes: Disable ACPI S3 and S4 with SPS
Hermes can be used with either CSME or SPS firmware. However, the SPS
(Server Platform Services) firmware does not support ACPI S3 and S4
sleep states, and coreboot should not report S3 and S4 as supported.
Add a Kconfig option to be selected when building coreboot to use with
SPS firmware, which allows disabling ACPI S3 and S4 sleep state support.
Change-Id: I9d0fa8530e198e86415f92da6719d2fb0d2401ec
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
---
M src/mainboard/prodrive/hermes/Kconfig
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/54058/1
diff --git a/src/mainboard/prodrive/hermes/Kconfig b/src/mainboard/prodrive/hermes/Kconfig
index 178acce..ac497e6 100644
--- a/src/mainboard/prodrive/hermes/Kconfig
+++ b/src/mainboard/prodrive/hermes/Kconfig
@@ -14,10 +14,18 @@
select INTEL_GMA_HAVE_VBT
select SOC_INTEL_COMMON_BLOCK_HDA_VERB
select ONBOARD_VGA_IS_PRIMARY
- select HAVE_ACPI_RESUME
+ select HAVE_ACPI_RESUME if !HERMES_USES_SPS_FIRMWARE
+ select DISABLE_ACPI_HIBERNATE if HERMES_USES_SPS_FIRMWARE
if BOARD_PRODRIVE_HERMES_BASEBOARD
+config HERMES_USES_SPS_FIRMWARE
+ bool "Build for use with SPS (Server Platform Services) firmware"
+ help
+ Depending on the intended use case, the Hermes mainboard can use either
+ CSME or SPS firmware SKUs. Choose this option if using SPS firmware, as
+ SPS doesn't support ACPI S3 and S4 sleep states.
+
config MAINBOARD_FAMILY
string
default "PRODRIVE_HERMES_SERIES"
To view, visit change 54058. To unsubscribe, or for help writing mail filters, visit settings.