[coreboot-gerrit] [S] Change in coreboot[master]: mb/starlabs: Remove the bios_version function

[Martin L Roth (Code Review)]

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70855 )

Change subject: mb/starlabs: Remove the bios_version function
......................................................................

mb/starlabs: Remove the bios_version function

Remove smbios_mainboard_bios_version so that the default
CONFIG_LOCALVERSION can be used.

Signed-off-by: Sean Rhodes 
Change-Id: Ia94f8683a54a98f4e3b1f51521db7e3ccb56ba48
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70855
Tested-by: build bot (Jenkins) 
Reviewed-by: Matt DeVillier 
---
M src/mainboard/starlabs/Kconfig
M src/mainboard/starlabs/lite/smbios.c
M src/mainboard/starlabs/starbook/smbios.c
3 files changed, 16 insertions(+), 14 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved

diff --git a/src/mainboard/starlabs/Kconfig b/src/mainboard/starlabs/Kconfig
index 4295ef4..4df0588 100644
--- a/src/mainboard/starlabs/Kconfig
+++ b/src/mainboard/starlabs/Kconfig
@@ -12,8 +12,4 @@
 config MAINBOARD_VENDOR
    default "Star Labs"

-config LOCAL_VERSION
-	string
-	default "8.18"
-
 endif # VENDOR_STARLABS
diff --git a/src/mainboard/starlabs/lite/smbios.c b/src/mainboard/starlabs/lite/smbios.c
index 511b28f..d9ae270 100644
--- a/src/mainboard/starlabs/lite/smbios.c
+++ b/src/mainboard/starlabs/lite/smbios.c
@@ -9,11 +9,6 @@
 #include <uuid.h>
 #include <variants.h>

-const char *smbios_mainboard_bios_version(void)
-{
-	return CONFIG_LOCAL_VERSION;
-}
-
 /* Get the Embedded Controller firmware version */
 void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision)
 {
diff --git a/src/mainboard/starlabs/starbook/smbios.c b/src/mainboard/starlabs/starbook/smbios.c
index 47280ce..ab2c211 100644
--- a/src/mainboard/starlabs/starbook/smbios.c
+++ b/src/mainboard/starlabs/starbook/smbios.c
@@ -9,11 +9,6 @@
 #include <uuid.h>
 #include <variants.h>

-const char *smbios_mainboard_bios_version(void)
-{
-	return CONFIG_LOCAL_VERSION;
-}
-
 /* Get the Embedded Controller firmware version */
 void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision)
 {