1 comment:
File src/soc/intel/icelake/romstage/fsp_params.c:
Patch Set #2, Line 59: m_cfg->VmxEnable = CONFIG(ENABLE_VMX);
This already configures VMX in FSP and set the feature lock bit (FC_LOCK MSR).
In FSP (CNL, TGL, so I expect ICL to be the same) is enabled and fc is locked only if SkipMpInit=0 && VmxEnable=1. Since ICL coreboot dropped SkipMpInit and switched to MP PPI usage, we have two options here:
1) Set FSP option VmxEnable from Kconfig as done above and do nothing else in coreboot
2) Set FSP option VmxEnable=0 statically and call set_vmx_and_lock() from cpu/intel/common
To view, visit change 45826. To unsubscribe, or for help writing mail filters, visit settings.