Patch Set 1:

I wonder if that commit just unmasked another issue.
When testing on Mandolin the IVRS table out of the HOB written by AGESA/FSP was so broken that the kernel (the version that is used in the live boot media of kubuntu 18.04 LTS; haven't checked which) just disabled the IOMMU altogether. The IVRS table generated by coreboot fixed at least that issue, so reverting it would cause a regression there.

This is causing complete instability on zork devices. Have you verified the coreboot IVRS table on zork with IOMMU turned on?

View Change

To view, visit change 44897. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idee1c7e829282427ee80f7d7071793b000936810
Gerrit-Change-Number: 44897
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@amd.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon@chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 28 Aug 2020 14:53:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment