(5 comments)

Thanks for writing this up. The relation to the `SkipMpInit` wasn't
clear to me before (I'm not 100% sure yet, but much closer).

Please make it clear if you intend to force usage of this interface
or if it is optional (for `SkipMpInit=1`).

Nothing is force here, its optional if you want to avoid FSP to use those interface which coreboot has published, then just set SkipMpInit=1, FSP won't call this APIs to run those feature programming over AP.

View Change

To view, visit change 25921. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6096ef31d8a523c00cbad39ab9d4884e735fde
Gerrit-Change-Number: 25921
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Patrick Georgi <pgeorgi@google.com>
Gerrit-Comment-Date: Tue, 01 May 2018 11:35:42 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No