Subrata Banik uploaded patch set #4 to this change.

View Change

arch/x86: Reserve some CAR memory for FSP single stack requirement

From FSP2.1 onwards stack and heap requirement has changed
(For documentation on this feature, please see page 25 of the
FSP v2.1 specification (https://cdrdv2.intel.com/v1/dl/getContent/611786))

arch_upd->StackBase will refer as Heap Start for HOB and arch_upd->StackSize
will be heap size.

As FSP and coreboot will same stack hence FSP doesn't need dedicated
UPD to pass stack start information.

But FSP might need to know where to keep HOB heap and for the same purpose
it usage StackBase and StackSize UPDs (names are confusing!)

Proposed to reserve a small region above _car_global_end with platform
given DACHE_BSP_HEAP_SIZE for FSP to keep HOB heap.

+--------------+ _car_region_end
| |
FSP stack end +--------------+ _car_heap_end
|heap |
FSP heap base +--------------+ _car_heap_start/_car_global_end
|car global |
+--------------+ _car_global_start
+--------------+ _car_relocatable_data_start
FSP stack end +--------------+ _car_stack_end
| |
+--------------+
|stack_guard |
FSP stack base +--------------+ _car_stack_start
|vboot |
+--------------+ _car_region_start

BUG=b:140268415

Change-Id: I943eff1225b976dc4440a6ca6d02ceea378319f8
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
---
M src/arch/x86/car.ld
M src/arch/x86/include/arch/symbols.h
M src/cpu/Kconfig
M src/drivers/intel/fsp2_0/memory_init.c
4 files changed, 46 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/35165/4

To view, visit change 35165. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I943eff1225b976dc4440a6ca6d02ceea378319f8
Gerrit-Change-Number: 35165
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kane Chen <kane.chen@intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath@intel.com>
Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone@intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Usha P <usha.p@intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: newpatchset