Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
src/pci_ids: add missing Intel Kaby Lake iGPU PCIIDs

Adds missing Intel HD/Iris iGPU PCI IDs for Kaby Lake processors and
updates the platform report for these devices.

These changes are in accordance with the documentation:
[*] page 10, Intel(R) Open Source HD Graphics and Intel Iris(TM) Plus
Graphics for the 2016 - 2017 Intel Core(TM) Processors, Celeron(TM)
Processors, and Pentium(TM) Processors based on the "Kaby Lake"
Platform. Programmer's Reference Manual. Volume 4: Configurations.
January 2017, Revision 1.0
Doc Ref # IHD-OS-KBL-Vol 4-1.17
[*] Linux kernel sources: include/drm/i915_pciids.h

Change-Id: I1cd1e4ab82f756141f8f13edf1c17f726166dffb
Signed-off-by: Maxim Polyakov <max.senia.poliak@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35544
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
---
M src/include/device/pci_ids.h
M src/soc/intel/common/block/graphics/graphics.c
M src/soc/intel/skylake/bootblock/report_platform.c
3 files changed, 38 insertions(+), 7 deletions(-)

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index 84896f6..b828eaa 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -3111,12 +3111,23 @@
#define PCI_DEVICE_ID_INTEL_SKL_GT3FE_SSRVM 0x192D
#define PCI_DEVICE_ID_INTEL_SKL_GT4_SHALM 0x193B
#define PCI_DEVICE_ID_INTEL_SKL_GT4E_SWSTM 0x193D
+#define PCI_DEVICE_ID_INTEL_KBL_GT1F_DT2 0x5902
#define PCI_DEVICE_ID_INTEL_KBL_GT1_SULTM 0x5906
+#define PCI_DEVICE_ID_INTEL_KBL_GT1_SHALM_1 0x5908
+#define PCI_DEVICE_ID_INTEL_KBL_GT1_SSRVM 0x590A
+#define PCI_DEVICE_ID_INTEL_KBL_GT1_SHALM_2 0x590B
#define PCI_DEVICE_ID_INTEL_KBL_GT2_DT2P2 0x5912
-#define PCI_DEVICE_ID_INTEL_KBL_GT2_SULXM 0x591E
#define PCI_DEVICE_ID_INTEL_KBL_GT2_SULTM 0x5916
#define PCI_DEVICE_ID_INTEL_KBL_GT2_SULTMR 0x5917
+#define PCI_DEVICE_ID_INTEL_KBL_GT2F_SULTM 0x5921
+#define PCI_DEVICE_ID_INTEL_KBL_GT2_SSRVM 0x591A
#define PCI_DEVICE_ID_INTEL_KBL_GT2_SHALM 0x591B
+#define PCI_DEVICE_ID_INTEL_KBL_GT2_SWSTM 0x591D
+#define PCI_DEVICE_ID_INTEL_KBL_GT2_SULXM 0x591E
+#define PCI_DEVICE_ID_INTEL_KBL_GT3E_SULTM_1 0x5926
+#define PCI_DEVICE_ID_INTEL_KBL_GT3E_SULTM_2 0x5927
+#define PCI_DEVICE_ID_INTEL_KBL_GT4_SHALM 0x593B
+
#define PCI_DEVICE_ID_INTEL_AML_GT2_ULX 0x591C
#define PCI_DEVICE_ID_INTEL_APL_IGD_HD_505 0x5a84
#define PCI_DEVICE_ID_INTEL_APL_IGD_HD_500 0x5a85
diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c
index c59fc53..8e79eab 100644
--- a/src/soc/intel/common/block/graphics/graphics.c
+++ b/src/soc/intel/common/block/graphics/graphics.c
@@ -136,11 +136,21 @@
PCI_DEVICE_ID_INTEL_WHL_GT1_ULT_1,
PCI_DEVICE_ID_INTEL_WHL_GT2_ULT_1,
PCI_DEVICE_ID_INTEL_KBL_GT1_SULTM,
+ PCI_DEVICE_ID_INTEL_KBL_GT1_SHALM_1,
+ PCI_DEVICE_ID_INTEL_KBL_GT1_SHALM_2,
+ PCI_DEVICE_ID_INTEL_KBL_GT1_SSRVM,
+ PCI_DEVICE_ID_INTEL_KBL_GT1F_DT2,
PCI_DEVICE_ID_INTEL_KBL_GT2_SULXM,
PCI_DEVICE_ID_INTEL_KBL_GT2_SULTM,
PCI_DEVICE_ID_INTEL_KBL_GT2_SULTMR,
+ PCI_DEVICE_ID_INTEL_KBL_GT2_SSRVM,
+ PCI_DEVICE_ID_INTEL_KBL_GT2_SWSTM,
PCI_DEVICE_ID_INTEL_KBL_GT2_SHALM,
PCI_DEVICE_ID_INTEL_KBL_GT2_DT2P2,
+ PCI_DEVICE_ID_INTEL_KBL_GT2F_SULTM,
+ PCI_DEVICE_ID_INTEL_KBL_GT3E_SULTM_1,
+ PCI_DEVICE_ID_INTEL_KBL_GT3E_SULTM_2,
+ PCI_DEVICE_ID_INTEL_KBL_GT4_SHALM,
PCI_DEVICE_ID_INTEL_AML_GT2_ULX,
PCI_DEVICE_ID_INTEL_SKL_GT1F_DT2,
PCI_DEVICE_ID_INTEL_SKL_GT1_SULTM,
diff --git a/src/soc/intel/skylake/bootblock/report_platform.c b/src/soc/intel/skylake/bootblock/report_platform.c
index d94ea99..0bd65c3 100644
--- a/src/soc/intel/skylake/bootblock/report_platform.c
+++ b/src/soc/intel/skylake/bootblock/report_platform.c
@@ -133,12 +133,22 @@
{ PCI_DEVICE_ID_INTEL_SKL_GT3FE_SSRVM, "Skylake Media Server GT3FE" },
{ PCI_DEVICE_ID_INTEL_SKL_GT4_SHALM, "Skylake HALO GT4" },
{ PCI_DEVICE_ID_INTEL_SKL_GT4E_SWSTM, "Skylake Workstation GT4E" },
- { PCI_DEVICE_ID_INTEL_KBL_GT1_SULTM, "Kabylake ULT GT1"},
- { PCI_DEVICE_ID_INTEL_KBL_GT2_SULXM, "Kabylake ULX GT2" },
- { PCI_DEVICE_ID_INTEL_KBL_GT2_SULTM, "Kabylake ULT GT2" },
- { PCI_DEVICE_ID_INTEL_KBL_GT2_SULTMR, "Kabylake-R ULT GT2"},
- { PCI_DEVICE_ID_INTEL_KBL_GT2_SHALM, "Kabylake HALO GT2" },
- { PCI_DEVICE_ID_INTEL_KBL_GT2_DT2P2, "Kabylake DT GT2" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT1F_DT2, "Kaby Lake DT GT1F" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT1_SULTM, "Kaby Lake ULT GT1" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT1_SHALM_1, "Kaby Lake HALO GT1" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT1_SHALM_2, "Kaby Lake HALO GT1" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT1_SSRVM, "Kaby Lake SRV GT1" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT2_SSRVM, "Kaby Lake Media Server GT2" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT2_SWSTM, "Kaby Lake Workstation GT2" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT2_SULXM, "Kaby Lake ULX GT2" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT2_SULTM, "Kaby Lake ULT GT2" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT2_SULTMR, "Kaby Lake-R ULT GT2" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT2_SHALM, "Kaby Lake HALO GT2" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT2_DT2P2, "Kaby Lake DT GT2" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT2F_SULTM, "Kaby Lake ULT GT2F" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT3E_SULTM_1, "Kaby Lake ULT (15W) GT3E" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT3E_SULTM_2, "Kaby Lake ULT (28W) GT3E" },
+ { PCI_DEVICE_ID_INTEL_KBL_GT4_SHALM, "Kaby Lake HALO GT4" },
{ PCI_DEVICE_ID_INTEL_AML_GT2_ULX, "Amberlake ULX GT2" },
};


To view, visit change 35544. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cd1e4ab82f756141f8f13edf1c17f726166dffb
Gerrit-Change-Number: 35544
Gerrit-PatchSet: 5
Gerrit-Owner: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged