Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38591 )
Change subject: Documentation/vendorcode/eltan: Update security document ......................................................................
Patch Set 10:
(9 comments)
Patch Set 9:
forgot to say: many of my comments are just minor issues, so feel free to discard any comment you don't want to act on.
Thanks for your remarks. I adressed the issues and created some clarifications that I hope will make it easier to understand.
https://review.coreboot.org/c/coreboot/+/38591/9/Documentation/vendorcode/el... File Documentation/vendorcode/eltan/security.md:
https://review.coreboot.org/c/coreboot/+/38591/9/Documentation/vendorcode/el... PS9, Line 15: the
drop "the"?
Done
https://review.coreboot.org/c/coreboot/+/38591/9/Documentation/vendorcode/el... PS9, Line 20: next
following
Done
https://review.coreboot.org/c/coreboot/+/38591/9/Documentation/vendorcode/el... PS9, Line 21: added
to the list? or to CBFS?
Done
https://review.coreboot.org/c/coreboot/+/38591/9/Documentation/vendorcode/el... PS9, Line 24: v
V
Done
https://review.coreboot.org/c/coreboot/+/38591/9/Documentation/vendorcode/el... PS9, Line 26: next
following
Done
https://review.coreboot.org/c/coreboot/+/38591/9/Documentation/vendorcode/el... PS9, Line 34: The
"A"?
Done
https://review.coreboot.org/c/coreboot/+/38591/9/Documentation/vendorcode/el... PS9, Line 35: specified item
I understand the rest of the text that this means "list itself", or is it really for each item in a […]
Done
https://review.coreboot.org/c/coreboot/+/38591/9/Documentation/vendorcode/el... PS9, Line 59: point to location of the public key
maybe "point to the public key file"?
Done
https://review.coreboot.org/c/coreboot/+/38591/9/Documentation/vendorcode/el... PS9, Line 96: next
following
Done