Attention is currently required from: Arthur Heymans, Nicholas Chin.
13 comments:
Patchset:
I noticed that your old MEC5055 patch in CB:44975 which your old E7240 port used sent a 0xAB command […]
I didn't know what the effect of this command is, just found it in the vendor firmware.
File Documentation/mainboard/dell/e7240.md:
Patch Set #2, Line 29: a programmer
Maybe make this more clear by using "an external programmer"
Done
Patch Set #2, Line 41: Schematic of this laptop can be found on [Lab One]. The board name is Compal LA-9431P.
It's not a formally written policy but it's probably not good idea for coreboot to link to documents […]
removed
[Lab One]: https://www.laboneinside.com/dell-latitude-e7240-schematic-diagram/
See prior comment about the schematic link
Done
File src/mainboard/dell/e7240/Kconfig:
Patch Set #2, Line 5: BOARD_ROMSIZE_KB_8192
Is this correct? The E7240 appears to have 2 flash chips, an 8MiB and a 4MiB
I can see one chip in my board, another place that can solder a flash chip is empty. The image is uploaded.
Patch Set #2, Line 17: string
Not necessary, as the type is already defined in `mb/Kconfig`
Done
Patch Set #2, Line 21: string
Same here, can be removed
Done
config VGA_BIOS_FILE
string
default "pci8086,0a16.rom"
Remove, see commit 05ae8f2ff3 (mainboard: Drop invalid `VGA_BIOS_FILE` defaults).
Done
Patch Set #2, Line 29: string
Can be removed
Done
Can be removed
Done
File src/mainboard/dell/e7240/Makefile.inc:
Missing SPDX header. […]
Done
File src/mainboard/dell/e7240/bootblock.c:
pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0x007c0901);
mec5035_early_init();
pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0);
Any reason to explicitly set and unset LPC_GEN4_DEC here? The devicetree entries for these are set u […]
Done
File src/mainboard/dell/e7240/devicetree.cb:
Patch Set #2, Line 66: device pci 1f.0 on end # LPC bridge
Did you try adding the EC here like the dell/e6400? That seems to call a function that initialized t […]
Done
To view, visit change 79746. To unsubscribe, or for help writing mail filters, visit settings.