Attention is currently required from: Elyes Haouas.

View Change

1 comment:

• File gfxtest/hw-gfx-gma-gfx_test.adb:

  • Patch Set #1, Line 54:

    Blue  : Byte;
          Green : Byte;
          Red   : Byte;
    

    I would keep using the RGB order […]

    Problem is, this record defines the byte ordering for the hardware. This patch should allow the RGB-to-BGR swizzling to be done at compile time, so that there's no extra runtime cost.

    If I were to use RGB ordering here, then `Pixel_To_Word` would have to unscramble the pixel, which is harder to work with.

To view, visit change 81854. To unsubscribe, or for help writing mail filters, visit settings.