Jacob Garber uploaded patch set #3 to this change.

View Change

soc/rockchip/rk3288: Add missing break statement

To break, or not to break, that is the question.
-- Hamlet, probably

The case statement for INIT_MEM does not have a break, and so falls
through to the one for CONF. Is this intentional, or is it a mistake?
Well, it doesn't completely matter, since if a break were added the
state would be CONF on the next iteration of the while loop, and so it
would execute the CONF case anyway. Let's add a break statement to be
consistent with the rest of the cases.

Change-Id: I1d0cfea07211c54d6a906f5a7481c2c760f8ef0d
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1291959
---
M src/soc/rockchip/rk3288/sdram.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/34296/3

To view, visit change 34296. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d0cfea07211c54d6a906f5a7481c2c760f8ef0d
Gerrit-Change-Number: 34296
Gerrit-PatchSet: 3
Gerrit-Owner: Jacob Garber <jgarber1@ualberta.ca>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Jacob Garber <jgarber1@ualberta.ca>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: newpatchset