Shelley Chen submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved
mb/google/brox: Enable Touchscreen

BUG=b:300690448,b:319393777
BRANCH=None
TEST=tested on a device with i2cdetect
Also tested with evtest and make sure Wacom is listed

Change-Id: I4f528b0d778c8c4a4e83774d5c167ccb2d6afd9a
Signed-off-by: Shelley Chen <shchen@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79895
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
M src/mainboard/google/brox/variants/baseboard/brox/gpio.c
2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
index be31df6..8ea21b0 100644
--- a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
+++ b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
@@ -168,6 +168,26 @@
device i2c 0x15 on end
end
end #I2C0
+ device ref i2c1 on
+ chip drivers/i2c/hid
+ register "generic.hid" = ""WACOM4A0D""
+ register "generic.desc" = ""BOE Touchscreen""
+ register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_F18_IRQ)"
+ register "generic.detect" = "1"
+ register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F17)"
+ register "generic.reset_delay_ms" = "100"
+ register "generic.reset_off_delay_ms" = "10"
+ register "generic.enable_gpio" =
+ "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_F7)"
+ register "generic.enable_delay_ms" = "6"
+ register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F16)"
+ register "generic.stop_off_delay_ms" = "100"
+ register "generic.has_power_resource" = "1"
+ register "hid_desc_reg_offset" = "0x01"
+ device i2c 0x0A on
+ end
+ end
+ end
device ref i2c4 on
chip drivers/i2c/tpm
register "hid" = ""GOOG0005""
diff --git a/src/mainboard/google/brox/variants/baseboard/brox/gpio.c b/src/mainboard/google/brox/variants/baseboard/brox/gpio.c
index da70da1..5432bd1 100644
--- a/src/mainboard/google/brox/variants/baseboard/brox/gpio.c
+++ b/src/mainboard/google/brox/variants/baseboard/brox/gpio.c
@@ -244,7 +244,7 @@
/* GPP_F6 : [NF1: CNV_PA_BLANKING NF6: USB_C_GPP_F6] ==> SOC_GPP_F6 (NC)*/
PAD_NC(GPP_F6, NONE),
/* GPP_F7 : [NF6: USB_C_GPP_F7] ==> EN_PP3300_TCHSCR */
- PAD_CFG_GPO(GPP_F7, 0, PLTRST),
+ PAD_CFG_GPO(GPP_F7, 1, PLTRST),
/* GPP_F9 : [NF1: BOOTMPC NF6: USB_C_GPP_F9] ==> SSD_PERST_L */
PAD_CFG_GPO(GPP_F9, 1, DEEP),
/* GPP_F10 : GPP_F10 ==> GPP_F10_STRAP (NC) */

To view, visit change 79895. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f528b0d778c8c4a4e83774d5c167ccb2d6afd9a
Gerrit-Change-Number: 79895
Gerrit-PatchSet: 25
Gerrit-Owner: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-MessageType: merged