29 Mar
2018
29 Mar
'18
8:43 a.m.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/25419 )
Change subject: soc/amd/common/block/pi/amd_late_init.c: Fix coverity issue CID 1387031 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/25419/1/src/soc/amd/common/block/pi/amd_late... File src/soc/amd/common/block/pi/amd_late_init.c:
https://review.coreboot.org/#/c/25419/1/src/soc/amd/common/block/pi/amd_late... PS1, Line 53: sizeof(dimm->module_part_number) - 1) Is this the correct solution here? Isn't this going to truncate the last byte of the spd's part number? Maybe use memcpy and manually terminate the string instead?
--
To view, visit https://review.coreboot.org/25419
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18fa5e9c73401575441b6810f1db80d11666368c
Gerrit-Change-Number: 25419
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin Roth martinroth@google.com
Gerrit-Comment-Date: Thu, 29 Mar 2018 06:43:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No