Felix Held submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Tim Van Patten: Looks good to me, approved
mb/google/skryim: Add RECOVERY_MRC_CACHE FMAP section

Enable HAS_RECOVERY_MRC_CACHE config and add RECOVERY_MRC_CACHE FMAP
section to cache the MRC training data in recovery mode.

BUG=b:270569389
TEST=Build and boot to OS in Skyrim. Ensure that the Type 0x63 BIOS
directory entry is populated with the appropriate MRC_CACHE FMAP
section.

Change-Id: I3f0f41c20b61c96473e887521f84f3ad240adc2b
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73250
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
---
M src/mainboard/google/skyrim/Kconfig
M src/mainboard/google/skyrim/chromeos.fmd
2 files changed, 24 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig
index 13fb804..22caf51 100644
--- a/src/mainboard/google/skyrim/Kconfig
+++ b/src/mainboard/google/skyrim/Kconfig
@@ -36,6 +36,7 @@
select FW_CONFIG
select FW_CONFIG_SOURCE_CHROMEEC_CBI
select GOOGLE_SMBIOS_MAINBOARD_VERSION
+ select HAS_RECOVERY_MRC_CACHE
select I2C_TPM
select MAINBOARD_HAS_CHROMEOS
select MAINBOARD_HAS_TPM2
diff --git a/src/mainboard/google/skyrim/chromeos.fmd b/src/mainboard/google/skyrim/chromeos.fmd
index 07d5f46..217fa98 100644
--- a/src/mainboard/google/skyrim/chromeos.fmd
+++ b/src/mainboard/google/skyrim/chromeos.fmd
@@ -22,6 +22,7 @@
RW_NVRAM(PRESERVE) 20K
SMMSTORE(PRESERVE)@0x630000 64K
RW_VBIOS_CACHE 64K
+ RECOVERY_MRC_CACHE(PRESERVE) 120K
RW_LEGACY(CBFS)
WP_RO@8M 8M {
RO_VPD(PRESERVE) 16K

To view, visit change 73250. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f0f41c20b61c96473e887521f84f3ad240adc2b
Gerrit-Change-Number: 73250
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jason Nien <jason.nien@amd.corp-partner.google.com>
Gerrit-Reviewer: Jon Murphy <jpmurphy@google.com>
Gerrit-Reviewer: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Gerrit-MessageType: merged