5 comments:
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
* macro: find_free_mtrr
* Clobbers %eax, %ebx, %ecx, %edx.
* If not found %ebx is 0.
* If found MTRR_BASE is at %ecx.
Is this macro returning a tuple as (%ebx, %ecx) ? The comment is not very clear.
Yes, how could it be more clear?
What does this refer to? Maybe call it "mtrr_found" instead ?
2f means 2 in forward direction, i.e. the next 2: in line 47
Is this a loop?
1 backwards, line 40
why decl here?
MTRRs come in pairs, one BASE followed by one MASK reg. We've checked a bit
in the MASK reg here, but want to return BASE, hence -1.
Patch Set #4, Line 133: inc %ecx
This looks wrong. […]
See above, returned %ecx is the BASE reg, +1 for the MASK reg.
To view, visit change 37190. To unsubscribe, or for help writing mail filters, visit settings.