Next time, please do two commits.
8 comments:
Patch Set #6, Line 7: mb/google/hatch: modify PCIe ports setting for mushu
Please be specific.
Enable dGPU and WLAN devices
Also, I believe Chromium devices use specific prefixes for variants.
Patch Set #6, Line 9: Enabled
Enable
port
Patch Set #6, Line 11: Enabled
Enable
File src/mainboard/google/hatch/variants/mushu/overridetree.cb:
Patch Set #6, Line 67: 13(x4)
Please add a space before (.
Patch Set #6, Line 67: # Enable Root port 13(x4) for dGPU.
Please remove the dot at the end.
Patch Set #6, Line 75: # PCIe port 8 reserve for GPU REFCLK
… reserve*d* for …
Patch Set #6, Line 87: register "PcieClkSrcClkReq[3]" = "3"
Shouldn’t this be sorted according to port numbers?
To view, visit change 38399. To unsubscribe, or for help writing mail filters, visit settings.