Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77990?usp=email )
Change subject: soc/amd/picasso: add eMMC MMIO device to devicetree
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
yep, this commenting out does allow me to get as far as I had previously gotten. […]
hm, this is unexpected. i'm not sure if the aoac registers direct;y control the hardware or if it makes some firmware on some of the embedded microprocessors do something. if the latter is the case, this might be due to using unsupported psp/smu/... binaries or it might be a mobile vs desktop thing. at least i verified that this patch didn't break things on mobile picasso when using the binaries from amb_blobs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77990?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5453b69df776d2ce1f3be11e37cd26c8c64f0cd5
Gerrit-Change-Number: 77990
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Marty E. Plummer
hanetzer@startmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 28 Sep 2023 18:47:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Marty E. Plummer
hanetzer@startmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment