3 comments:
To make it easier to pop arguments from stack use size_t instead of int.
This is a noop on x86_32.
POP r32 instruction is marked N.E. (not encodable) in 64-bit mode.
added to commit message
File src/arch/x86/postcar_loader.c:
Patch Set #4, Line 32: pcf->stack -= sizeof(val); \
It's confusing with x86_64 if you allow the stack pointer to break alignment to 8 bytes.
Done
Patch Set #4, Line 99: stack_push(pcf, addr | type);
Proper aligment of values on the stack might be lost here with x86_64.
Done
To view, visit change 32375. To unsubscribe, or for help writing mail filters, visit settings.