Attention is currently required from: Arthur Heymans, Jérémy Compostella, Patrick Rudolph, Saurabh Mishra, Subrata Banik.

View Change

1 comment:

• Patchset:

  • Patch Set #3:

    In current implementation fast_spi uses memcpy() and it is clear that the change in memcpy() broke it.
    We can make memcpy() to any no. of bytes, but it shouldn't break existing code that depend on memcpy() and cause regression on existing platforms. Also saying using memcpy() is "wrong" is wrong. It's a valid approach.

    However, I do see that switching to write32p() would be a better alternative without changing memcpy() yet again and have pushed a new patch here: https://review.coreboot.org/c/coreboot/+/82079

To view, visit change 81959. To unsubscribe, or for help writing mail filters, visit settings.