Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Tim Chu.
View Change
1 comment:
Patchset:
Patch Set #2:
Thanks, Nico. […]
There are indeed some valuable learnings obtained from this long journey (thanks for all of you being with me on tackling many many issues).
For complex ASL objects, there are many corner cases cannot be covered by one or two system tests (TEST=...), we have to rely on code review to make sure no defects. Compared to the AML generating codes, ASL is more readable to human beings and hence should be considered first.
P.S. the reason for the many many issues captured in the previous round of review is that, I directly used the iasl decoded ASL from the previous generated AML, and it surprised myself as well that so many details are not handled correctly.
Have parameterized ASL handlers is a good solution to cover this case and future usages as well (Thanks for Nico to raise this as a suggestion in the mail discussion). I think we should move ahead to make this even more general,
e.g. Can we pass a buffer list instead of being limited to use 8 parameters of an ACPI method?
e.g. Can we improve the name space isolation so that we might have a concept of library of many handlers in future?
This will definitely make coreboot as a stronger solution to cover multi-segment usage in the long run, which is the common target of all. Look forward to more good ideas from you.
To view, visit change 82034. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibd3bfa2428725fe593754436d5ed75a3a11b4cdc
Gerrit-Change-Number: 82034
Gerrit-PatchSet: 3
Gerrit-Owner: Shuo Liu <shuo.liu@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang@gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan@9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang@gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter@9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan@9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 08:21:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Shuo Liu <shuo.liu@intel.com>
Gerrit-MessageType: comment