View Change
1 comment:
Commit Message:
Patch Set #2, Line 15: - remove redundant MAINBOARD_VERSION option
because it just mirrored the board name, it wasn't being used to differentiate between board revisio […]
It's used to fill the SMBIOS table. Just seems odd to
remove that. Or actually, leave it at the default "1.0".
But it has a prompt anyway, so it's up to the person
configuring the build. And I assume I'm talking to the
one who does it for the official builds, so I won't
argue ;)
To view, visit change 32515. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic09b8ec5c576f4c4c48ef30ee3f60a4c2c286cd3
Gerrit-Change-Number: 32515
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Wed, 01 May 2019 19:25:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier@gmail.com>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment