7 comments:
Patch Set #2, Line 34: #endif
> This sort of stuff shouldn't be here. You'll probably want to centralize it in src/lib/imd_cbmem. […]
Done
Patch Set #15, Line 25: #include <cbmem.h>
This compilation unit doesn't technically need this header.
Now it does with the extern symbol declared in there.
Patch Set #15, Line 32: uintptr_t _cbmem_top_ptr;
It doesn't need a similar function. It just needs to set the variable. […]
Done
> I think this needs an ENV_RAMSTAGE check like the arm64 version? […]
Done
Patch Set #15, Line 36: _cbmem_top_ptr = (uintptr_t)stage_arg;
Not really sure I understand the second part of what you said, maybe that would be clearer if you up […]
Done
Patch Set #16, Line 34: if (!ENV_ROMSTAGE)
This needs to be either ENV_RAMSTAGE or !ENV_ROMSTAGE_OR_BEFORE. […]
Done
nit: If you want this as a uintptr_t, just make it a uintptr_t.
Done
To view, visit change 36145. To unsubscribe, or for help writing mail filters, visit settings.