8 comments:
Patch Set #2, Line 7: SPM: mt8183: support spm suspend in coreboot
Please use the common prefix (see `git log --oneline`).
Ack
Test by powerd_dbus_suspend (it would call linux suspend to ram) […]
Ack
Patch Set #2, Line 11: Change-Id: I3393a772f025b0912a5a25a63a87512454fbc86e
ok, I would update on next version.
Ack
File src/soc/mediatek/mt8183/spm.c:
Patch Set #2, Line 225: CBFS_TYPE_RAW);
ok, I would update on next version.
Ack
Patch Set #2, Line 243: BIOS_INFO
ok, I would update on next version.
not updated yet?
Patch Set #2, Line 244: (unsigned int)(unsigned long)
This is for print dram address of pcmdesc->base […]
this seems not fixed yet. please replace by %p without casting.
Patch Set #2, Line 305: spm_load_firmware(index);
I would try to add on next version.
Ack
Patch Set #2, Line 310: printk(BIOS_ERR, "SPM: firmware is not ready!!!\n");
User need check dram type and if this driver could get right firmware. […]
Ack
To view, visit change 34545. To unsubscribe, or for help writing mail filters, visit settings.