You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32245 )
Change subject: mediatek: Use the 64-bit timer
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32245/4/src/soc/mediatek/common/timer.c
File src/soc/mediatek/common/timer.c:
https://review.coreboot.org/#/c/32245/4/src/soc/mediatek/common/timer.c@33
PS4, Line 33: high = read32(&mtk_gpt->gpt6_cnt_h);
: low = read32(&mtk_gpt->gpt6_cnt_l);
It seems like the variable 'high' and 'low' are always zero on Kukui.
Besides, the datasheet of MT8183 mentioned that,
reading GPT6_COUNTL will make GPT6_COUNTH fixed until next read operation of GPT6_COUNTL.
Does this mean we can read the timer without a loop?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32245
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f080e47253a1b1bab4636a45cb86c8666a25302
Gerrit-Change-Number: 32245
Gerrit-PatchSet: 4
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Apr 2019 00:20:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment