Patch Set 15:

(2 comments)

Thanks for more context, but it'm still not clear.

Thanks for the review! The SoC patch was reworked (in particular src/soc/intel/xeon_sp/chip.c), now this patch is not needed anymore.

View Change

To view, visit change 38547. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69e100ea658fefec905321197b5bd6da1e0e647a
Gerrit-Change-Number: 38547
Gerrit-PatchSet: 15
Gerrit-Owner: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Andrey Petrov <anpetrov@fb.com>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 12 Feb 2020 01:08:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment