Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Subrata Banik: Looks good to me, approved
mb/intel/mtlrvp: streamline Chrome EC configs

Chrome EC configuration options that are common among
various boards have been consolidated under the
"BOARD_EXT_EC_SPECIFIC_OPTIONS" config.

BUG=b:289783489
TEST=emerge-rex coreboot chromeos-bootimage is successful

Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f
Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79211
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
---
M src/mainboard/intel/mtlrvp/Kconfig
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/intel/mtlrvp/Kconfig b/src/mainboard/intel/mtlrvp/Kconfig
index b541b76..c4478d1 100644
--- a/src/mainboard/intel/mtlrvp/Kconfig
+++ b/src/mainboard/intel/mtlrvp/Kconfig
@@ -41,6 +41,10 @@
def_bool n
select BOARD_INTEL_MTLRVP_COMMON
select DRIVERS_INTEL_PMC
+ select EC_ACPI
+ select EC_GOOGLE_CHROMEEC
+ select EC_GOOGLE_CHROMEEC_ESPI
+ select EC_GOOGLE_CHROMEEC_BOARDID
select FW_CONFIG
select FW_CONFIG_SOURCE_CHROMEEC_CBI

@@ -109,11 +113,7 @@
Select whether the board has Intel EC or/and Chrome EC

config MTL_CHROME_EC
- bool "Chrome EC"
- select EC_ACPI
- select EC_GOOGLE_CHROMEEC
- select EC_GOOGLE_CHROMEEC_ESPI
- select EC_GOOGLE_CHROMEEC_BOARDID
+ bool "Chrome EC with Internal SPI flash"

config MTL_INTEL_EC
bool "Intel EC"

To view, visit change 79211. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f
Gerrit-Change-Number: 79211
Gerrit-PatchSet: 12
Gerrit-Owner: Deepti Deshatty <deepti.deshatty@intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d@intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged