Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Kapil Porwal, Nico Huber, Patrick Rudolph.
1 comment:
File src/arch/x86/boot.c:
Patch Set #3, Line 47: is_payload_64_bit_enabled
On x86_32 coreboot you do not properly handle the case when someone inserts a 64-bit payload into the CBFS. Since the flag is a build time option and you only evaluate it at runtime at end of boot, there should be either support for it or an error message.
do you recommend to insert a `die` if x86_32 coreboot attempts to boot a 64-bit payload ? that way we know this is unsupported combination ?
basically at line number https://review.coreboot.org/c/coreboot/+/81960/3..7/src/arch/x86/boot.c#75
To view, visit change 81960. To unsubscribe, or for help writing mail filters, visit settings.