7 comments:
File src/commonlib/bsd/cbfs_private.c:
Patch Set #4, Line 54: goto next_file;
I was just trying to continue where possible and skip over broken files rather than abort completely […]
(Continued in https://review.coreboot.org/c/coreboot/+/38421/11/src/commonlib/bsd/cbfs_private.c#75)
cbfs_walk() checks (data_offset > sizeof(mdata)) and (data_offset < attr_offset), so I think these c […]
(Continued in https://review.coreboot.org/c/coreboot/+/38421/11/src/commonlib/bsd/cbfs_private.c#117)
File src/commonlib/bsd/cbfs_private.c:
Patch Set #8, Line 8: size_t devsize
Maybe constify this?
Done
Patch Set #8, Line 30: bool do_hash
Maybe constify this?
Done
File src/commonlib/bsd/include/commonlib/bsd/cbfs_private.h:
Patch Set #4, Line 69: * the remaining CBFS (but not call |walker| anymore).
This is already supposed to be the underlying workhorse function, the wrappers are things like cbfs_ […]
Resolved?
Patch Set #4, Line 91: offset to the file data
Not sure what you mean, relative to what? This is absolute. […]
Done
File src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h:
Patch Set #4, Line 131: struct vb2_hash hash;
Yes, this struct is supposed to have a somewhat dynamic length. […]
Done
To view, visit change 38421. To unsubscribe, or for help writing mail filters, visit settings.