You could try to run all the new files through clang-format.

View Change

8 comments:

• Commit Message:

  • Patch Set #1, Line 7: mediaek

    mediatek

  • Patch Set #1, Line 8:

    Where is the data sheet (or the name, revision), and is that driver written from scratch or taken from, for example, U-Boot?

• File src/soc/mediatek/mt8183/dsi.c:

  • Patch Set #1, Line 23: static void mipi_write32(void *a, uint32_t offset, uint32_t v)

    Are these all common functions, which can be shared?

  • Patch Set #1, Line 98: BIOS_ERR

    Why is this an error? BIOS_INFO or NOTICE?

  • Patch Set #1, Line 139: udelay(30);

    Is that delay mentioned in the data sheet?

  • Patch Set #1, Line 415: Timeout

    time-out

  • Patch Set #1, Line 415: dsi DONE INT Timeout

    Please rephrase to be better understandable, and also add the stop watch time.

  • Patch Set #1, Line 416:

    Please add a debug message, detailing how long it took by printing the stopwatch value.

To view, visit change 31591. To unsubscribe, or for help writing mail filters, visit settings.