Patch set 8:Code-Review -1
2 comments:
File src/soc/intel/tigerlake/chip.h:
Patch Set #8, Line 113: PchHdaIDispCodecDisconnect
Here, default value of 0 means connected and 1 is disconnected. I am wondering if this config should be named IDispEnabled or something on those lines so that it can be set only by the mainboards that enable IDisp?
File src/soc/intel/tigerlake/romstage/fsp_params_tgl.c:
m_cfg->PchHdaAudioLinkDmicClkAPinMux[0] = GPIO_VER2_LP_MUXING_DMIC0_CLKA_GPP_S6;
m_cfg->PchHdaAudioLinkDmicClkBPinMux[0] = GPIO_VER2_LP_MUXING_DMIC0_CLKB_GPP_S2;
m_cfg->PchHdaAudioLinkDmicDataPinMux[0] = GPIO_VER2_LP_MUXING_DMIC0_DATA_GPP_S7;
m_cfg->PchHdaAudioLinkDmicClkAPinMux[1] = GPIO_VER2_LP_MUXING_DMIC1_CLKA_GPP_S4;
m_cfg->PchHdaAudioLinkDmicClkBPinMux[1] = GPIO_VER2_LP_MUXING_DMIC1_CLKB_GPP_S3;
m_cfg->PchHdaAudioLinkDmicDataPinMux[1] = GPIO_VER2_LP_MUXING_DMIC1_DATA_GPP_S5;
Let's not do this here. I think doing the pinmux config in coreboot should be fine.
To view, visit change 38147. To unsubscribe, or for help writing mail filters, visit settings.