View Change

8 comments:

• File src/soc/qualcomm/common/include/soc/qclib_common.h:

  • Patch Set #1, Line 66: uint64_t reserved; /* 0x18 */

    please, no space before tabs

  • Patch Set #1, Line 73: void add_if_table_entry(const char *, void *, uint32_t, uint32_t);

    function definition argument 'const char *' should also have an identifier name

  • Patch Set #1, Line 73: void add_if_table_entry(const char *, void *, uint32_t, uint32_t);

    function definition argument 'void *' should also have an identifier name

  • Patch Set #1, Line 73: void add_if_table_entry(const char *, void *, uint32_t, uint32_t);

    function definition argument 'uint32_t' should also have an identifier name

  • Patch Set #1, Line 73: void add_if_table_entry(const char *, void *, uint32_t, uint32_t);

    function definition argument 'uint32_t' should also have an identifier name

  • Patch Set #1, Line 74: void write_ddr_information(struct qclib_cb_if_table_entry *);

    function definition argument 'struct qclib_cb_if_table_entry *' should also have an identifier name

  • Patch Set #1, Line 75: void write_qclib_log_to_cbmemc(struct qclib_cb_if_table_entry *);

    function definition argument 'struct qclib_cb_if_table_entry *' should also have an identifier name

  • Patch Set #1, Line 76: void write_table_entry(struct qclib_cb_if_table_entry *);

    function definition argument 'struct qclib_cb_if_table_entry *' should also have an identifier name

To view, visit change 32288. To unsubscribe, or for help writing mail filters, visit settings.