3 comments:
File src/soc/intel/alderlake/romstage/fsp_params.c:
Patch Set #28, Line 41: return m_cfg->PcieRpEnableMask
not sure if that is a good idea because the function only returns valid results after the fsp mask w […]
This already done by lookup devicetree. It had run m_cfg->PcieRpEnableMask = pcie_rp_enable_mask(get_pch_pcie_rp_table()) before call this.
pcie_is_flag_enabled(cfg[i], PCIE_RP_CLK_REQ_UNUSED))
m_cfg->PcieClkSrcClkReq[cfg[i].clk_src] = cfg[i].clk_req;
m_cfg->PcieClkSrcUsage[cfg[i].clk_src] =
convert_clk_src_to_fsp(type, cfg[i], i);
this won't be executed when the port is enabled (line 53)
oh... I forgot the ! in line53.. thanks.
Patch Set #28, Line 157: CONFIG_MAX_ROOT_PORTS
why pass that als parameter instead of using it in the function?
What do you mean? I think Kconfig if fine.
To view, visit change 48340. To unsubscribe, or for help writing mail filters, visit settings.