Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik.
Hello Kapil Porwal, Pranava Y N, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84616?usp=email
to look at the new patch set (#2).
Change subject: soc/intel/pantherlake: Remove soc_info.[hc] interface ......................................................................
soc/intel/pantherlake: Remove soc_info.[hc] interface
This commit removes the unnecessary layer provided by soc_info.[hc]. It was providing an abstraction which only was resulting in extra function calls without any added value as the returned constants are well identified and could be used directly. More importantly, and this is the actual selling point in my opinion, this extra indirection was preventing the compiler from detecting array overflows.
BUG=348678529 TEST=Build is successful
Change-Id: Iea26d962748116fa84afdb4afcba1098a64b6986 Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com --- M src/soc/intel/pantherlake/Makefile.mk M src/soc/intel/pantherlake/cpu.c M src/soc/intel/pantherlake/elog.c D src/soc/intel/pantherlake/include/soc/soc_info.h M src/soc/intel/pantherlake/pcie_rp.c M src/soc/intel/pantherlake/romstage/fsp_params.c D src/soc/intel/pantherlake/soc_info.c 7 files changed, 3 insertions(+), 84 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/84616/2