Martin Roth has posted comments on this change. ( https://review.coreboot.org/22679 )
Change subject: google/kahlee: Set USB OC pins ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants... File src/mainboard/google/kahlee/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants... PS1, Line 50: return 0; Do we need to add something to disable the other 2?
*map |= USB_OC_DISABLE << OC_PORT2_SHIFT; *map |= USB_OC_DISABLE << OC_PORT3_SHIFT;
https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants... File src/mainboard/google/kahlee/variants/kahlee/gpio.c:
https://review.coreboot.org/#/c/22679/1/src/mainboard/google/kahlee/variants... PS1, Line 155: *map &= ~(USB_OC_DISABLE << OC_PORT0_SHIFT); wouldn't it be cleaner just to disable ports 2 & 3?