Felix Held submitted this change.

View Change

Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Sumeet R Pawnikar: Looks good to me, but someone else must approve
mb/google/brya/var/omniknight: Add WIFI SAR table

Add WIFI SAR table for omniknight.

BUG=b:320172979
TEST=FW_NAME=omnigul emerge-brya coreboot

Change-Id: I70e79577612b3d5c4dc0f92211f87cbea0532d5d
Signed-off-by: jamie_chen <jamie_chen@compal.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80152
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
---
M src/mainboard/google/brya/variants/omnigul/overridetree.cb
M src/mainboard/google/brya/variants/omnigul/variant.c
2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/brya/variants/omnigul/overridetree.cb b/src/mainboard/google/brya/variants/omnigul/overridetree.cb
index 4a3d368..1801672 100644
--- a/src/mainboard/google/brya/variants/omnigul/overridetree.cb
+++ b/src/mainboard/google/brya/variants/omnigul/overridetree.cb
@@ -4,6 +4,10 @@
option STORAGE_UFS 1
option STORAGE_NVME 2
end
+ field WIFI_SAR_TABLE 5
+ option OMNIGUL_WIFI_SAR_0 0
+ option OMNIKNIGHT_WIFI_SAR_1 1
+ end
field FINGERPRINT 9
option DISABLE_FP 0
option ENABLE_FP 1
diff --git a/src/mainboard/google/brya/variants/omnigul/variant.c b/src/mainboard/google/brya/variants/omnigul/variant.c
index 6a79780..67cef1f 100644
--- a/src/mainboard/google/brya/variants/omnigul/variant.c
+++ b/src/mainboard/google/brya/variants/omnigul/variant.c
@@ -1,8 +1,14 @@
/* SPDX-License-Identifier: GPL-2.0-only */

#include <sar.h>
+#include <fw_config.h>

const char *get_wifi_sar_cbfs_filename(void)
{
- return "wifi_sar_0.hex";
+ if (fw_config_probe(FW_CONFIG(WIFI_SAR_TABLE, OMNIGUL_WIFI_SAR_0)))
+ return "wifi_sar_0.hex";
+ if (fw_config_probe(FW_CONFIG(WIFI_SAR_TABLE, OMNIKNIGHT_WIFI_SAR_1)))
+ return "wifi_sar_1.hex";
+
+ return NULL;
}

To view, visit change 80152. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70e79577612b3d5c4dc0f92211f87cbea0532d5d
Gerrit-Change-Number: 80152
Gerrit-PatchSet: 11
Gerrit-Owner: Jamie Chen <jamie_chen@compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang@google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Ivan Chen <yulunchen@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng@compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Van Chen <van_chen@compal.corp-partner.google.com>
Gerrit-MessageType: merged