[coreboot-gerrit] Patch set updated for coreboot: a11df88 kirby: Clean some cruft from mainboard.c

[Patrick Georgi]

Patrick Georgi ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4413

-gerrit

commit a11df88a9ea549bc525d4326b499db503e160a2b
Author: Gabe Black 
Date:   Tue Jul 30 22:43:47 2013 -0700

kirby: Clean some cruft from mainboard.c

1. Kirby doesn't have a backlight enable GPIO on the AP since that's handled
    entirely by the DP-to-LVDS bridge.
    2. There is no tps65090 on the other side of the EC who's settings need to be
    adjusted. If we need to turn on the LCD or backlight power manually, it will
    have to be done in a different way.
    3. The PMIC doesn't provide a 32KHz output for the audio codec.

Change-Id: Iadc5f3aec4818805edf3f2517da9e6fee87085dc
    Signed-off-by: Gabe Black 
    Reviewed-on: https://gerrit.chromium.org/gerrit/63883
    Commit-Queue: Gabe Black 
    Reviewed-by: Gabe Black 
    Tested-by: Gabe Black 
---
 src/mainboard/google/kirby/mainboard.c | 33 +--------------------------------
 1 file changed, 1 insertion(+), 32 deletions(-)

diff --git a/src/mainboard/google/kirby/mainboard.c b/src/mainboard/google/kirby/mainboard.c
index 9975202..064d0f1 100644
--- a/src/mainboard/google/kirby/mainboard.c
+++ b/src/mainboard/google/kirby/mainboard.c
@@ -172,7 +172,6 @@ static enum exynos5_gpio_pin dp_pd_l = GPIO_X35;	/* active low */
 static enum exynos5_gpio_pin dp_rst_l = GPIO_Y77;	/* active low */
 static enum exynos5_gpio_pin dp_hpd = GPIO_X26;		/* active high */
 static enum exynos5_gpio_pin bl_pwm = GPIO_B20;		/* active high */
-static enum exynos5_gpio_pin bl_en = GPIO_X22;		/* active high */

static void parade_dp_bridge_setup(void)
 {
@@ -224,12 +223,6 @@ static void backlight_pwm(void)
    udelay(LCD_T6_DELAY_MS * 1000);
 }

-static void backlight_en(void)
-{
-	/* Configure GPIO for LCD_BL_EN */
-	gpio_direction_output(bl_en, 1);
-}
-
 //static struct video_info smdk5420_dp_config = {
 static struct video_info dp_video_info = {
    /* FIXME: fix video_info struct to use const for name */
@@ -273,33 +266,12 @@ static void gpio_init(void)
    exynos_pinmux_i2c10();
 }

-enum {
-	FET_CTRL_WAIT = 3 << 2,
-	FET_CTRL_ADENFET = 1 << 1,
-	FET_CTRL_ENFET = 1 << 0
-};
-
-static void tps65090_thru_ec_fet_set(int index)
-{
-	uint8_t value = FET_CTRL_ADENFET | FET_CTRL_WAIT | FET_CTRL_ENFET;
-
-	if (google_chromeec_i2c_xfer(0x48, 0xe + index, 1, &value, 1, 0)) {
-		printk(BIOS_ERR,
-		       "Error sending i2c pass through command to EC.\n");
-		return;
-	}
-}
-
 static void lcd_vdd(void)
 {
-	/* Enable FET6, lcd panel */
-	tps65090_thru_ec_fet_set(6);
 }

static void backlight_vdd(void)
 {
-	/* Enable FET1, backlight */
-	tps65090_thru_ec_fet_set(1);
 }

/* this happens after cpu_init where exynos resources are set */
@@ -332,7 +304,6 @@ static void mainboard_init(device_t dev)

backlight_vdd();
    backlight_pwm();
-	backlight_en();

// Uncomment to get excessive GPIO output:
    // gpio_info();
@@ -372,11 +343,9 @@ static void mainboard_enable(device_t dev)
    clock_epll_set_rate(epll_hz);
    clock_select_i2s_clk_source();
    clock_set_i2s_clk_prescaler(epll_hz, sample_rate * lr_frame_size);
-
-	power_enable_xclkout();
 }

struct chip_operations mainboard_ops = {
-	.name	= "Samsung/Google ARM Chromebook",
+	.name	= "Google ARM Chromebook",
    .enable_dev = mainboard_enable,
 };