View Change

9 comments:

• File src/soc/qualcomm/common/include/soc/qclib_common.h:

  • Patch Set #2, Line 19: #include <fmap.h>

    nit: I think this is only needed in the . […]

    Ack

• File src/soc/qualcomm/common/qclib.c:

  • Patch Set #2, Line 136: qclib_add_if_table_entry(QCLIB_TE_QCLIB_LOG_BUFFER, _qclib_serial_log,

    line over 80 characters

    Ack

  • Patch Set #2, Line 140: 0

    nit: technically, this one should be NULL, not 0

    Ack

  • Patch Set #2, Line 147: qclib_add_if_table_entry(QCLIB_TE_DDR_TRAINING_DATA, _ddr_training, size, 0);

    line over 80 characters

    Ack

  • Patch Set #2, Line 151: WARNING

    nit: anything that makes DDR init fail should probably at least be ERROR

    Ack

  • Patch Set #2, Line 157: qclib_cb_if_table.global_attributes =

    nit: let's write this as |= just in case we add new code for other attributes above later

    Ack

  • Patch Set #2, Line 162:

    nit: it's odd to have a tab here, is that intentional?

    Ack

  • Patch Set #2, Line 171: qcsdi.entry

    nit: use prog_entry(&qcsdi) (below as well, and for &qclib)

    Ack

  • Patch Set #2, Line 215: QCLIB_BA_SAVE_TO_STORAGE)

    nit: indent this continuation line one more tab so it's clearer to distinguish from the if-body belo […]

    Ack

To view, visit change 32288. To unsubscribe, or for help writing mail filters, visit settings.