Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41155 )
Change subject: soc/intel/common/block/systemagent: Use TOUUD as base for MMIO above 4G ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41155/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41155/2//COMMIT_MSG@9 PS2, Line 9: TOUDD
TOUUD.
Done
https://review.coreboot.org/c/coreboot/+/41155/2/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/41155/2/src/soc/intel/common/block/... PS2, Line 118: if (!get_enable_above_4GB_mmio())
Subrata, I'm confused by the not enough room comment. […]
I looked at the "Not enough PCI address space for a large BAR" message in kernel and it seems to come from pci_resize_resource() with return value -ENOSPC. This is basically when pci_reassign_bridge_resources() fails to assign resources to the device. So, it does look like providing the right MMIO window above 4G should allow the kernel to allocate resources and should not lead to the not enough room error. Let's move forward with this change for now and once you are able to test this, we can revisit this to see if there are any problems.