Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Ren Kuo: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
mb/google/dedede/var/magolor: Remove the unused touch controller

Remove unused touch controller - Goodix

BUG=None
BRANCH=dedede
TEST=build firmware

Signed-off-by: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Change-Id: I2a01666bc1e353e21ddf961a0eb721a0cb4013db
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49221
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 0 insertions(+), 15 deletions(-)

diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
index 0a92402..78d5dde 100644
--- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
@@ -152,21 +152,6 @@
end # I2C 0
device pci 15.2 on
chip drivers/i2c/hid
- register "generic.hid" = ""GDIX0000""
- register "generic.desc" = ""Goodix Touchscreen""
- register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
- register "generic.probed" = "1"
- register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
- register "generic.reset_delay_ms" = "120"
- register "generic.reset_off_delay_ms" = "2"
- register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)"
- register "generic.enable_delay_ms" = "12"
- register "generic.has_power_resource" = "1"
- register "generic.disable_gpio_export_in_crs" = "1"
- register "hid_desc_reg_offset" = "0x01"
- device i2c 0x5d on end
- end
- chip drivers/i2c/hid
register "generic.hid" = ""ELAN6915""
register "generic.desc" = ""ELAN Touchscreen""
register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"

To view, visit change 49221. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a01666bc1e353e21ddf961a0eb721a0cb4013db
Gerrit-Change-Number: 49221
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Henry Sun <henrysun@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Chen <tim-chen@quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged